wrolpi/app/cypress/e2e
lrnselfreliance aff5f1eb1f
A directory rename is finished by the file worker, not the request (#950)
* A directory rename is finished by the file worker, not the request

A directory rename queued a move, waited for it, then removed the old
directory and updated nested Collections itself.  A rename that outlasted
Sanic's RESPONSE_TIMEOUT (60 s) was cancelled while waiting: the move still
finished, but the old directory and its emptied subdirectories were left
behind, nested Collections kept their old directories, and the browser was
told the rename failed.

The move job now finishes the rename (nested Collections, then removing the
old directory, empty directories only), and the request returns once the
move is queued.  A failure is reported by the job's event.  An empty
directory can be renamed (it raised before).  The worker status carries
`rename_from`, so the Files page progress bar labels the rename, and the
file browser fetches again when the file worker is done.

A directory rename no longer queues a refresh of its parent: the file
worker runs the newest task first, so it scanned the directory before the
rename.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* A queued rename returns its job, and the file browser waits for it

Review fixes:

- The cancellation test patched `wait_for_job`, which this path no longer
  calls, so it cancelled nothing.  It now asserts the invariant: the
  request only queues the rename (it never waits, and nothing has moved
  when it returns), and the file worker alone finishes it.

- The file browser inferred the end of a rename from the file worker's
  polled status.  A short job can start and finish between two polls, and
  the first idle poll (before the job started) spent the "fetch once"
  token, so the table could keep the old name.  POST /api/files/rename now
  returns `{"job_id": ...}` (null when the rename is already done), GET
  /api/files/jobs/<job_id> reports pending/complete/failed, and the file
  browser polls that job before fetching.

- useBrowseFiles ignores a fetch that settles after a newer one, so a
  listing requested before a rename cannot replace the one after it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-07 13:09:33 -07:00
..
calculators Speed Test calculator: ping, download, and upload against the API (#708) 2026-09-13 18:47:18 -06:00
domains ui: the last of Semantic UI, in name and in dead CSS 2026-08-08 18:05:54 -06:00
files A directory rename is finished by the file worker, not the request (#950) 2026-11-07 13:09:33 -07:00
forms Updating cypress tests for new file group routes. 2026-03-21 16:26:08 -06:00
settings Add a Repos module that mirrors git repositories (#783) 2026-10-07 15:16:58 -06:00
caddy-media.cy.js Skipping Caddy tests on CICD. 2026-03-10 20:30:46 -06:00
keyboard-shortcuts.cy.js review: close the mixed-unit gaps the scale left behind 2026-08-08 18:05:51 -06:00
map-themes.cy.js test: act on review -- the sprite gap, and the branch no e2e can reach 2026-08-08 18:05:48 -06:00