lrnselfreliance a93630576f Tests fail when a request writes outside request.ctx.db.write() (#864) ... * Tests fail when a request writes outside request.ctx.db.write() A request's transaction begins deferred. A write in it after a read fails instantly ("database is locked") when another connection wrote in between, and a write left for the response middleware's commit can be lost after the response was sent. #846-#853 and #863 moved handlers' writes into request.ctx.db.write(); this keeps it that way. Under pytest, a listener records every INSERT/UPDATE/DELETE/REPLACE made while a request runs (or in a task it started) outside RequestDB.write() or get_db_session(commit=True), and the autouse no_deferred_request_writes fixture fails the test. allow_deferred_request_writes opts a test out. The test-only response listener now runs switches outside the request, as production's perpetual process does. It found three more: - DELETE /api/zim/<ids> deleted the .zim file, returned 204, then lost the row's delete when the middleware's commit failed under contention. It now writes in request.ctx.db.write(). - Viewing a file recorded the view in a background task on the request's Session, after the request ended. set_file_viewed opens its own write. - tags.import_config (startup and config import) read, then wrote, in a deferred get_db_session(). It now begins as a writer. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Tasks don't inherit a declared write; tags import change backed out From review of #864: - background_task's task copied its creator's Context, including _write_intent when started inside get_db_session(commit=True) or RequestDB.write(), so the guard ignored the task's own writes for its lifetime. The task now starts with no declared write. That exposes fetch_channel_source_id (started by the channels config import): it read the Channel, asked the remote site for its source_id, then committed in the same deferred transaction. It now reads, fetches with no transaction open, then writes in a short get_db_session(commit=True). - tags.import_config: commit=True held the write lock through its directory walk, and its exit commit saved changes the need_commit gate used to drop. Reverted to master; splitting its reads from a short write is its own change. The two tests that run it through a request are marked allow_deferred_request_writes until then. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>		2026-10-23 17:09:39 -06:00
..
archive	Apply the offset in a SingleFile saved date, and repair misread Archive dates (#862)	2026-10-23 14:34:29 -06:00
docs	Model reprs read only loaded state (#819)	2026-10-11 16:47:32 -06:00
flasher	db: request-path library functions use the request's connection (#774)	2026-10-04 11:05:20 -06:00
inventory	Strip whitespace from inventory item string values on save	2026-07-30 17:34:46 -06:00
map	Channel and map subscription changes wait for a concurrent writer (#851)	2026-10-21 16:48:52 -06:00
repos	Repo changes wait for a concurrent writer (#853)	2026-10-21 16:50:09 -06:00
videos	Tests fail when a request writes outside request.ctx.db.write() (#864)	2026-10-23 17:09:39 -06:00
zim	Tests fail when a request writes outside request.ctx.db.write() (#864)	2026-10-23 17:09:39 -06:00
__init__.py	Add a Repos module that mirrors git repositories (#783)	2026-10-07 15:16:58 -06:00