c8afc0e059
The other half of CI's cypress-e2e failure: `clicking search icon opens modal` failed with `expected '<input.wrolpi-searchbox-input>' to be 'visible'`, covered by a danger toast. Toasts paint above modals on purpose -- z-index 400 against the modal stack's 200 -- so an error raised while a modal is open stays visible. The search modal is tall, so it sits near the top of the window, and a top-right toast covers the right-hand 192px of its 365px input. Cypress occlusion-checks a `position: fixed` element, so the assertion failed. Measured at both scales, because the question was whether the interface scale caused it: 130px of a 330px input before, 192px of 365px after. The overlap is PRE-EXISTING; the scale widened it from 39% of the input to 53%, which is what pushed CI over the line. Roland's call was to accept the overlap -- an error toast belongs on top -- and fix the test. It passed locally and failed in CI because CI serves the React app with no API behind it. The endpoints this spec leaves unmocked are `/api/tag`, `/api/events/feed`, `/api/files/search` and `/api/files/worker_status` -- note that the spec's existing mocks say `/api/tags` and `/api/events`, neither of which the app calls -- so they fail and api.js raises "Unexpected server response". The toast container is removed before the assertion rather than clicked away, because a click races the next failing call. A blanket `/api/**` 200 stub was tried first and does not work: a 200 with the wrong shape fails the same way, which is what "Unexpected server response" means. Verified by reproducing CI's condition locally (`forceNetworkError` on every unmocked endpoint): 12 passing with the removal, 11 passing and 1 failing without it. All 50 e2e specs pass under normal conditions. |
||
|---|---|---|
| .. | ||
| cypress | ||
| public | ||
| scripts | ||
| src | ||
| .gitignore | ||
| cypress.config.js | ||
| package-lock.json | ||
| package.json | ||
| README.md | ||
| serve.json | ||
| tsconfig.json | ||
Getting Started with Create React App
This project was bootstrapped with Create React App.
Available Scripts
In the project directory, you can run:
npm start
Runs the app in the development mode.
Open http://localhost:3000 to view it in your browser.
The page will reload when you make changes.
You may also see any lint errors in the console.
npm test
Launches the test runner in the interactive watch mode.
See the section about running tests for more
information.
npm run build
Builds the app for production to the build folder.
It correctly bundles React in production mode and optimizes the build for the best performance.
The build is minified and the filenames include the hashes.
Your app is ready to be deployed!
See the section about deployment for more information.
npm run eject
Note: this is a one-way operation. Once you eject, you can't go back!
If you aren't satisfied with the build tool and configuration choices, you can eject at any time. This command will
remove the single build dependency from your project.
Instead, it will copy all the configuration files and the transitive dependencies (webpack, Babel, ESLint, etc) right
into your project so you have full control over them. All of the commands except eject will still work, but they will
point to the copied scripts so you can tweak them. At this point you're on your own.
You don't have to ever use eject. The curated feature set is suitable for small and middle deployments, and you
shouldn't feel obligated to use this feature. However we understand that this tool wouldn't be useful if you couldn't
customize it when you are ready for it.
Learn More
You can learn more in the Create React App documentation.
To learn React, check out the React documentation.
Code Splitting
This section has moved here: https://facebook.github.io/create-react-app/docs/code-splitting
Analyzing the Bundle Size
This section has moved here: https://facebook.github.io/create-react-app/docs/analyzing-the-bundle-size
Making a Progressive Web App
This section has moved here: https://facebook.github.io/create-react-app/docs/making-a-progressive-web-app
Advanced Configuration
This section has moved here: https://facebook.github.io/create-react-app/docs/advanced-configuration
Deployment
This section has moved here: https://facebook.github.io/create-react-app/docs/deployment
npm run build fails to minify
This section has moved here: https://facebook.github.io/create-react-app/docs/troubleshooting#npm-run-build-fails-to-minify