mirror of
https://github.com/lrnselfreliance/wrolpi.git
synced 2026-10-26 19:01:39 -04:00
29f35fcc7d
`semantic-ui-react`, `react-semantic-toasts-2` and `semantic-ui-offline` are
gone from package.json, the lockfile and node_modules -- 19 MB of dependencies
that nothing had imported since the migration finished.
Four things still referenced them and would have broken on uninstall. None was
caught by a build or by jest:
Four test files still ran `jest.mock('react-semantic-toasts-2', ...)` for
components that no longer use it. A jest.mock of a module that does not exist
throws, so the packages could not have come out without this.
`src/components/Download.cy.js` and `cypress/support/component.js` both
imported semantic.min.css. The support file now loads what the app loads --
index.css, the font and token stylesheets, and Mantine's.
The ratchet changes job rather than being deleted. An import of a missing module
fails loudly now, but three quieter mistakes would not: a `className="ui button"`
that styles nothing, a file reaching back through Theme.tsx, and someone
reinstalling a package to "just use one Semantic component". It asserts all
three, plus that package.json names nothing matching /semantic/i.
Two pre-existing problems in the cypress component harness surfaced while
checking the uninstall had not broken it, both fixed because that file had to be
edited anyway:
It imported `react-router-dom`, which is not installed -- this app is on
react-router v7. Dates to
|
||
|---|---|---|
| .. | ||
| BatchReorganizeModal.js | ||
| BatchReorganizeModal.test.js | ||
| CollectionEditForm.js | ||
| CollectionEditForm.test.js | ||
| CollectionReorganizeModal.js | ||
| CollectionReorganizeModal.test.js | ||
| CollectionTable.js | ||
| CollectionTable.test.js | ||
| CollectionTagModal.js | ||
| CollectionTagModal.test.js | ||
| ConflictResolutionModal.js | ||
| ConflictResolutionModal.test.js | ||