mirror of
https://github.com/lrnselfreliance/wrolpi.git
synced 2026-10-26 19:01:39 -04:00
* videos: codec download preferences with transcode and strict-fail options
Add video_codecs/audio_codecs ordered preference lists to the video,
channel, and RSS downloaders, alongside the existing resolution
selector. Codec preference is codec-major: a preferred codec at a
lower resolution beats another codec at a higher resolution.
When 'transcode' is enabled, a downloaded file whose streams do not
match the preferences is re-encoded with ffmpeg after download (only
the mismatching stream; targets are extensible maps, currently h264
and aac/opus/mp3). When 'strict_codecs' is enabled and transcode is
not, a download with no matching format fails permanently instead of
falling back.
Empty codec lists produce a byte-identical yt-dlp command to before.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* videos: honor strict_codecs when transcode cannot produce the preference
Review fixes:
- strict_codecs is now suppressed only when transcoding can produce a
preferred codec for every non-empty preference list (new
transcode_can_satisfy_codecs); av1-only preferences with transcode
enabled fail under strict instead of silently keeping the file.
- No partial transcode: an unfixable video mismatch blocks an
audio-only conversion (and vice versa); the mismatch falls through
to strict/keep.
- fsync the transcode output before rename, and the directory after,
so power loss on a Pi cannot leave a truncated final file.
- mp3 yt-dlp pattern matches mp4a.6B as well as mp4a.6b.
- ffmpeg maps use 0:V:0 (excludes attached pictures) and 0🅰️0?
(tolerates missing audio).
- Strict toggle is no longer disabled by transcode in the UI; popup
wording corrected.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* videos: serialize transcodes machine-wide via shared_ctx lock
Sanic runs multiple worker processes, so an asyncio primitive cannot
serialize transcodes across download workers. A multiprocessing.Lock
in shared_ctx now guarantees only one ffmpeg transcode runs at a time
on the machine; waiting workers poll the lock asynchronously so the
event loop stays responsive while a transcode holds it for hours.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* videos: transcode-lock review fixes
- Document that a crashed lock holder requires an API restart; this is
accepted rather than adding owner-death recovery.
- Move the 'Transcoding' user notification to after the lock is
acquired, so it fires when work begins rather than before a
potentially hours-long wait.
- Soften the lock test docstring to what it measures (in-process
wait/release); trim the acquire docstring to the polling rationale.
- Give transcode_lock its own section header in contexts.py.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
209 lines
8.6 KiB
Python
209 lines
8.6 KiB
Python
import asyncio
|
|
import os
|
|
import pathlib
|
|
import shutil
|
|
from typing import List, Optional, Tuple
|
|
|
|
from wrolpi.captions import FFMPEG_BIN
|
|
from wrolpi.cmd import run_command
|
|
from wrolpi.common import logger
|
|
from wrolpi.vars import DEFAULT_FILE_PERMISSIONS, PYTEST
|
|
|
|
logger = logger.getChild(__name__)
|
|
|
|
# How often a waiting worker re-checks the machine-wide transcode lock.
|
|
TRANSCODE_LOCK_POLL_SECONDS = 0.1 if PYTEST else 10
|
|
|
|
# ffprobe `codec_name` values that satisfy each user-selectable codec preference.
|
|
FFPROBE_VIDEO_CODEC_NAMES = {
|
|
'h264': {'h264'},
|
|
'hevc': {'hevc', 'h265'},
|
|
'vp9': {'vp9'},
|
|
'av1': {'av1'},
|
|
'vp8': {'vp8'},
|
|
}
|
|
FFPROBE_AUDIO_CODEC_NAMES = {
|
|
'aac': {'aac'},
|
|
'opus': {'opus'},
|
|
'mp3': {'mp3'},
|
|
'vorbis': {'vorbis'},
|
|
}
|
|
|
|
# Codecs which can be a transcode *target*, mapped to their ffmpeg encoder args. VP9/AV1/HEVC are
|
|
# omitted because software encoding them is impractically slow on a Raspberry Pi.
|
|
TRANSCODE_VIDEO_TARGETS = {
|
|
'h264': ('-c:v', 'libx264', '-preset', 'medium', '-crf', '23'),
|
|
}
|
|
TRANSCODE_AUDIO_TARGETS = {
|
|
'aac': ('-c:a', 'aac', '-b:a', '192k'),
|
|
'opus': ('-c:a', 'libopus', '-b:a', '128k'),
|
|
'mp3': ('-c:a', 'libmp3lame', '-q:a', '2'),
|
|
}
|
|
|
|
# Containers that can hold an h264/aac transcode result. webm cannot.
|
|
TRANSCODE_CONTAINERS = ('mp4', 'mkv')
|
|
|
|
TRANSCODE_TIMEOUT = 4 * 60 * 60 # A long video on a Raspberry Pi can take hours.
|
|
|
|
# Transcoding writes a whole new copy of the video next to the original.
|
|
MINIMUM_FREE_SPACE_RATIO = 1.5
|
|
|
|
|
|
def get_stream_codec_names(ffprobe_data: dict, codec_type: str) -> List[str]:
|
|
"""Return the codec_name of every stream of the given type ('video' or 'audio').
|
|
|
|
Embedded thumbnails appear as mjpeg/png video streams; they are not real video."""
|
|
streams = (ffprobe_data or {}).get('streams') or []
|
|
names = [s.get('codec_name') for s in streams if s.get('codec_type') == codec_type]
|
|
if codec_type == 'video':
|
|
names = [i for i in names if i not in ('mjpeg', 'png')]
|
|
return [i for i in names if i]
|
|
|
|
|
|
def codecs_match(ffprobe_data: dict, video_codecs: List[str], audio_codecs: List[str]) \
|
|
-> Tuple[bool, bool]:
|
|
"""Return (video matches, audio matches) for the codec preferences.
|
|
|
|
An empty preference list always matches. A missing stream also matches (an audio-only file
|
|
has no video stream to enforce)."""
|
|
video_match = True
|
|
if video_codecs:
|
|
names = get_stream_codec_names(ffprobe_data, 'video')
|
|
if names:
|
|
acceptable = set().union(*(FFPROBE_VIDEO_CODEC_NAMES.get(i, {i}) for i in video_codecs))
|
|
video_match = any(i in acceptable for i in names)
|
|
audio_match = True
|
|
if audio_codecs:
|
|
names = get_stream_codec_names(ffprobe_data, 'audio')
|
|
if names:
|
|
acceptable = set().union(*(FFPROBE_AUDIO_CODEC_NAMES.get(i, {i}) for i in audio_codecs))
|
|
audio_match = any(i in acceptable for i in names)
|
|
return video_match, audio_match
|
|
|
|
|
|
def get_transcode_target(preferences: List[str], targets: dict) -> Optional[str]:
|
|
"""The first preferred codec that is a supported transcode target, or None."""
|
|
for codec in preferences or []:
|
|
if codec in targets:
|
|
return codec
|
|
return None
|
|
|
|
|
|
def transcode_can_satisfy_codecs(video_codecs: List[str], audio_codecs: List[str]) -> bool:
|
|
"""True only if transcoding could produce a preferred codec for every non-empty preference
|
|
list. When False, enabling transcode cannot guarantee the preferences (e.g. av1-only), so
|
|
strict_codecs must still be honored."""
|
|
return ((not video_codecs or get_transcode_target(video_codecs, TRANSCODE_VIDEO_TARGETS) is not None)
|
|
and (not audio_codecs or get_transcode_target(audio_codecs, TRANSCODE_AUDIO_TARGETS) is not None))
|
|
|
|
|
|
async def _acquire_transcode_lock():
|
|
"""Block (asynchronously) until this process holds the machine-wide transcode lock.
|
|
|
|
Polled with sleep instead of a blocking acquire so a multi-hour ffmpeg hold elsewhere does
|
|
not stall this worker's event loop."""
|
|
from wrolpi.api_utils import api_app
|
|
lock = api_app.shared_ctx.transcode_lock
|
|
if not lock.acquire(block=False):
|
|
logger.info('Waiting for another transcode to finish')
|
|
while not lock.acquire(block=False):
|
|
await asyncio.sleep(TRANSCODE_LOCK_POLL_SECONDS)
|
|
return lock
|
|
|
|
|
|
async def transcode_video_file(video_path: pathlib.Path,
|
|
target_vcodec: Optional[str] = None,
|
|
target_acodec: Optional[str] = None,
|
|
container: str = 'mp4') -> pathlib.Path:
|
|
"""Transcode a video file in place (same stem, possibly a new container extension).
|
|
|
|
Only one transcode runs at a time machine-wide (across all Sanic workers); this call waits
|
|
for its turn. Only the stream(s) with a target are re-encoded; the other stream is copied.
|
|
The output is written to a temporary file in the same directory, then atomically renamed over
|
|
the final path. The original file is deleted if the extension changed. Returns the final
|
|
path.
|
|
|
|
@raise RuntimeError: when ffmpeg fails, or there is not enough free disk space.
|
|
"""
|
|
if not FFMPEG_BIN:
|
|
raise RuntimeError('ffmpeg was not found')
|
|
if not target_vcodec and not target_acodec:
|
|
raise RuntimeError('Refusing to transcode without a target codec')
|
|
if container not in TRANSCODE_CONTAINERS:
|
|
logger.info(f'Forcing mp4 container for transcode of {video_path} ({container} is not supported)')
|
|
container = 'mp4'
|
|
|
|
lock = await _acquire_transcode_lock()
|
|
try:
|
|
return await _transcode_video_file(video_path, target_vcodec, target_acodec, container)
|
|
finally:
|
|
lock.release()
|
|
|
|
|
|
async def _transcode_video_file(video_path: pathlib.Path, target_vcodec: Optional[str],
|
|
target_acodec: Optional[str], container: str) -> pathlib.Path:
|
|
"""The ffmpeg work of `transcode_video_file`; the caller holds the transcode lock."""
|
|
# Notify here, after the lock: the wait for another transcode can last hours, and the user
|
|
# should hear "Transcoding" only when this file's work actually begins.
|
|
try:
|
|
from wrolpi.events import Events
|
|
Events.send_user_notify(f'Transcoding {video_path.name}')
|
|
except Exception:
|
|
# Events are best-effort; never let them break a download.
|
|
logger.debug(f'Failed to send transcode event for {video_path}', exc_info=True)
|
|
|
|
source_size = video_path.stat().st_size
|
|
free = shutil.disk_usage(video_path.parent).free
|
|
if free < MINIMUM_FREE_SPACE_RATIO * source_size:
|
|
raise RuntimeError(
|
|
f'Not enough free space to transcode {video_path} ({free} bytes free, source is {source_size} bytes)')
|
|
|
|
video_args = TRANSCODE_VIDEO_TARGETS[target_vcodec] if target_vcodec else ('-c:v', 'copy')
|
|
audio_args = TRANSCODE_AUDIO_TARGETS[target_acodec] if target_acodec else ('-c:a', 'copy')
|
|
|
|
final_path = video_path.with_suffix(f'.{container}')
|
|
tmp_path = video_path.with_suffix(f'.transcode.{container}')
|
|
# 0:V:0 excludes attached-picture streams (embedded thumbnails); 0:a:0? tolerates a video
|
|
# with no audio stream.
|
|
cmd = (FFMPEG_BIN, '-y',
|
|
'-i', video_path,
|
|
'-map', '0:V:0', '-map', '0:a:0?',
|
|
*video_args,
|
|
*audio_args,
|
|
'-movflags', '+faststart',
|
|
str(tmp_path))
|
|
logger.warning(f'Transcoding {video_path} to {final_path} (video={target_vcodec}, audio={target_acodec})')
|
|
try:
|
|
result = await run_command(cmd, cwd=video_path.parent, timeout=TRANSCODE_TIMEOUT)
|
|
if result.return_code != 0:
|
|
raise RuntimeError(
|
|
f'ffmpeg exited with {result.return_code} while transcoding {video_path}:'
|
|
f'\n{result.stderr.decode()[-2000:]}')
|
|
except Exception:
|
|
tmp_path.unlink(missing_ok=True)
|
|
raise
|
|
|
|
# fsync before the rename: a Pi losing power after the rename must not be left with a
|
|
# truncated final file.
|
|
fd = os.open(tmp_path, os.O_RDONLY)
|
|
try:
|
|
os.fsync(fd)
|
|
finally:
|
|
os.close(fd)
|
|
|
|
# The old ffprobe sidecar describes the old streams.
|
|
video_path.with_suffix('.ffprobe.json').unlink(missing_ok=True)
|
|
tmp_path.rename(final_path)
|
|
if final_path != video_path:
|
|
video_path.unlink()
|
|
final_path.chmod(DEFAULT_FILE_PERMISSIONS)
|
|
|
|
# fsync the directory so the rename itself is durable.
|
|
fd = os.open(video_path.parent, os.O_RDONLY)
|
|
try:
|
|
os.fsync(fd)
|
|
except OSError:
|
|
pass # Some filesystems refuse directory fsync; the rename is still atomic.
|
|
finally:
|
|
os.close(fd)
|
|
return final_path
|