mirror of
https://github.com/lrnselfreliance/wrolpi.git
synced 2026-11-20 23:16:17 -05:00
Phase 2, part 4. Baseline 50 -> 15.
Migrated: all eight calculators, the rest of inventory and collections, the
Map/Zim/Docs cluster, Videos, Files, Search, Archive, DashboardPage,
DatesSelector, HelpModal, Events, Tags, Flasher's neighbours, admin Settings
and Status, Download, and App.
Also the three shared modules everything imports: api.js and customHooks.js
swap the Semantic toast library for the library's shim (same call shape), and
useForm.js renders the library's Message. useForm accepts both the old
`{content, header, positive|negative}` shape and the new `{kind, title}`,
because the pages building those objects migrate separately.
Two library gaps closed, both found by call sites needing them:
ActionInput is a forwardRef now. Its ref reaches the input rather than the
wrapper, because callers use it to focus or select the field -- a ref to the
surrounding div would do neither, which is why one call site had resorted to
hand-copying the component's markup.
Header takes a `color` token name. Three separate call sites had reached for
an inline style to colour a heading that carries meaning ("3 items to add"
against "2 to remove"), which is how a hex ends up in markup.
Two files needed repair after being interrupted mid-edit: MapViewer had a
Segment left in its error branch, and VideoPlayer had lost the useContext
import its own code still used. Neither jest nor tsc noticed; only
`npm run build` did, which is the whole reason that check exists.
Fifteen files remain: Archive, BulkTagModal, Channels, Docs, FileBrowser,
FilePreview, Flasher, Nav, Playlists, Theme.tsx, Upload, VideoPlayer, Zim,
ControllerPage, admin/Downloads. Theme.tsx is deliberately last -- the
unmigrated files still import its Semantic-backed wrappers, so it can only go
once they have.
53 lines
2.6 KiB
JavaScript
53 lines
2.6 KiB
JavaScript
import React from "react";
|
|
import {fireEvent, render, screen} from "../../test-utils";
|
|
import {FieldSchemaEditor} from "./FieldSchemaEditor";
|
|
|
|
const FIELDS = [
|
|
{key: 'name', label: 'Name', type: 'text', order: 0},
|
|
{key: 'category', label: 'Category', type: 'select', options: [], order: 1},
|
|
];
|
|
|
|
describe('FieldSchemaEditor select options', () => {
|
|
test('typing a comma is preserved while editing (does not get swallowed)', () => {
|
|
render(<FieldSchemaEditor fields={FIELDS} open={true} onClose={jest.fn()} onSave={jest.fn()}/>);
|
|
const optionsInput = screen.getByPlaceholderText('comma,separated,options');
|
|
|
|
// Typing the comma after the first option must not be stripped — otherwise a second option can't be started.
|
|
fireEvent.change(optionsInput, {target: {value: 'screws,'}});
|
|
expect(optionsInput.value).toBe('screws,');
|
|
|
|
fireEvent.change(optionsInput, {target: {value: 'screws,nails'}});
|
|
expect(optionsInput.value).toBe('screws,nails');
|
|
});
|
|
|
|
test('"Count by Weight" adds the linked weight + computed-count fields and they persist on save', async () => {
|
|
const onSave = jest.fn();
|
|
render(<FieldSchemaEditor fields={[{key: 'name', label: 'Name', type: 'text'}]}
|
|
open={true} onClose={jest.fn()} onSave={onSave}/>);
|
|
|
|
fireEvent.click(screen.getByText('Count by Weight'));
|
|
// The note appears on the computed Count row.
|
|
expect(screen.getByText(/Total Weight ÷ Unit Weight/)).toBeTruthy();
|
|
|
|
fireEvent.click(screen.getByText('Save Fields'));
|
|
const saved = onSave.mock.calls[0][0];
|
|
const byKey = Object.fromEntries(saved.map(f => [f.key, f]));
|
|
expect(byKey.unit_weight).toMatchObject({type: 'quantity', unit: 'g'});
|
|
expect(byKey.total_weight).toMatchObject({type: 'quantity', unit: 'g'});
|
|
// The compute metadata survives save() so the table can auto-fill the count.
|
|
expect(byKey.count.compute).toEqual({kind: 'count_by_weight', total: 'total_weight', unit: 'unit_weight'});
|
|
});
|
|
|
|
test('options are trimmed and emptied-out on save', async () => {
|
|
const onSave = jest.fn();
|
|
render(<FieldSchemaEditor fields={FIELDS} open={true} onClose={jest.fn()} onSave={onSave}/>);
|
|
const optionsInput = screen.getByPlaceholderText('comma,separated,options');
|
|
|
|
fireEvent.change(optionsInput, {target: {value: 'screws, nails ,'}});
|
|
fireEvent.click(screen.getByText('Save Fields'));
|
|
|
|
const savedFields = onSave.mock.calls[0][0];
|
|
const category = savedFields.find(f => f.key === 'category');
|
|
expect(category.options).toEqual(['screws', 'nails']);
|
|
});
|
|
});
|