wrolpi/app/src/components
Roland 90c2868c4f
review: record why make-directory is wider than rename
Acting on the review of #628.  No bugs; one suggestion and one nit, and the
suggestion is answered with a measurement rather than a change.

The review asked whether MakeDirectoryModal should drop back to `small`, on the
grounds that its body -- a path, one field and a button -- is the same shape as
RenameModal's, which is `small`.  The shapes are the same; the content is not.
Rename shows a RELATIVE path, make-directory shows the absolute one including the
media directory, and a bare `<pre>` is `white-space: pre`, so it scrolls out of
sight rather than wrapping.

Measured in the browser at both widths: 440px holds 42 characters, 620px holds 61.
`/media/wrolpi/videos/Practical Engineering/Season 2024/` is 55.  So an ordinary
channel-and-season path is unreadable at 440 and fits at 620, which is exactly
the condition the review set for keeping it.  The dev tree hides this -- its
paths are around 22 characters and fit either way.

Both `large` call sites now carry the audit comment the other three had, which
was the nit.  Make-directory's records the measurement, because it does read like
an inconsistency beside rename and the next person to notice should see the
numbers before narrowing it back.

1134 jest / 64 suites (--maxWorkers=2; see the previous commit), clean build.
2026-08-08 18:05:51 -06:00
..
admin ui: only the top modal answers Escape, and the audited widths 2026-08-08 18:05:49 -06:00
calculators fix: break the import cycle that put useCalculators in the TDZ 2026-08-08 18:05:47 -06:00
collections ui: only the top modal answers Escape, and the audited widths 2026-08-08 18:05:49 -06:00
inventory ui: only the top modal answers Escape, and the audited widths 2026-08-08 18:05:49 -06:00
ui style: spell it "color" everywhere 2026-08-08 18:05:50 -06:00
AddToPlaylist.js ui: Common.js and thirteen more files off Semantic 2026-08-08 18:04:00 -06:00
Apps.js fix: break the import cycle that put useCalculators in the TDZ 2026-08-08 18:05:47 -06:00
Archive.js ui: cards get legible titles, contained posters, and meta beside the title 2026-08-08 18:05:47 -06:00
ArchivePreview.js ui: Common.js and thirteen more files off Semantic 2026-08-08 18:04:00 -06:00
BulkTagModal.js ui: only the top modal answers Escape, and the audited widths 2026-08-08 18:05:49 -06:00
BulkTagModal.test.js ui: migrate Downloads, Upload, and BulkTagModal off Semantic 2026-08-08 18:04:02 -06:00
Calculators.js ui: fix the cypress failures, and two real defects behind them 2026-08-08 18:04:01 -06:00
CbzViewer.js ui: Common.js and thirteen more files off Semantic 2026-08-08 18:04:00 -06:00
Channels.cy.js Moving form fields. 2025-12-06 15:11:37 -07:00
Channels.js ui: only the top modal answers Escape, and the audited widths 2026-08-08 18:05:49 -06:00
Common.js style: spell it "color" everywhere 2026-08-08 18:05:50 -06:00
Common.test.js style: spell it "color" everywhere 2026-08-08 18:05:50 -06:00
DatesSelector.js ui: thirty-five files off Semantic, leaving fifteen 2026-08-08 18:04:01 -06:00
DesktopToggle.test.js ui: Common.js and thirteen more files off Semantic 2026-08-08 18:04:00 -06:00
Docs.js ui: migrate Docs.js and Zim.js off Semantic UI React 2026-08-08 18:04:01 -06:00
DomainEditPage.test.js app: handle form fetch failures without unhandled rejection 2026-07-16 19:40:28 -06:00
DomainsPage.test.js Reformatting code. 2025-12-06 15:11:37 -07:00
DomainTagging.test.js test: one place for fixtures, real providers instead of mocked context modules 2026-08-08 18:04:04 -06:00
DonatePage.js ui: only the top modal answers Escape, and the audited widths 2026-08-08 18:05:49 -06:00
Download.cy.js build: uninstall Semantic UI 2026-08-08 18:04:03 -06:00
Download.js ui: thirty-five files off Semantic, leaving fifteen 2026-08-08 18:04:01 -06:00
Download.test.js Reformatting code. 2025-12-06 15:11:37 -07:00
ErrorBoundary.js ui: nine leaf files off Semantic, and the components they needed 2026-08-08 18:04:00 -06:00
FileBrowser.js review: record why make-directory is wider than rename 2026-08-08 18:05:51 -06:00
FileBrowser.test.js test: the theme drives the colour scheme, and mockModule takes the module 2026-08-08 18:04:04 -06:00
FilePreview.js ui: only the top modal answers Escape, and the audited widths 2026-08-08 18:05:49 -06:00
FilePreview.test.js File preview: Open in Slicer button for STL/3MF files. 2026-07-05 13:31:40 -06:00
Files.js ui: size the five modals that had never been sized 2026-08-08 18:05:50 -06:00
Flasher.js ui: only the top modal answers Escape, and the audited widths 2026-08-08 18:05:49 -06:00
Flasher.test.js ui: migrate Flasher.js off Semantic UI React 2026-08-08 18:04:02 -06:00
Headline.js ui: nine leaf files off Semantic, and the components they needed 2026-08-08 18:04:00 -06:00
HelpModal.js ui: thirty-five files off Semantic, leaving fifteen 2026-08-08 18:04:01 -06:00
KeyboardShortcutsProvider.js ui: only the top modal answers Escape, and the audited widths 2026-08-08 18:05:49 -06:00
Map.js review: name the icon-only controls, and make two guards mean what they say 2026-08-08 18:05:50 -06:00
Map.test.js review: name the icon-only controls, and make two guards mean what they say 2026-08-08 18:05:50 -06:00
MapSearchView.js ui: centre the pagination strip 2026-08-08 18:05:47 -06:00
MapViewer.js ui: the monochrome themes draw a black basemap, not a dark one 2026-08-08 18:05:48 -06:00
Nav.js style: spell it "color" everywhere 2026-08-08 18:05:50 -06:00
otp.js Move One-Time Pad encryption to the browser (#479) 2026-06-13 13:52:34 -06:00
otp.test.js Move One-Time Pad encryption to the browser (#479) 2026-06-13 13:52:34 -06:00
Placeholder.js ui: Common.js and thirteen more files off Semantic 2026-08-08 18:04:00 -06:00
Playlists.js ui: Channels.js and Playlists.js off Semantic 2026-08-08 18:04:01 -06:00
Playlists.test.js Add ordered collections (playlists): polymorphic items + item API (#475) 2026-06-11 19:46:34 -06:00
Search.js ui: the corner triggers, the More button, and the search modal 2026-08-08 18:05:49 -06:00
SearchFilterModal.test.js ui: thirty-five files off Semantic, leaving fifteen 2026-08-08 18:04:01 -06:00
Share.js ui: only the top modal answers Escape, and the audited widths 2026-08-08 18:05:49 -06:00
ShortcutHint.js Displaying cmd+k/ctrl+k global search keyboard shortcut suggestion. 2026-02-23 16:07:22 -07:00
SortableTable.js ui: nine leaf files off Semantic, and the components they needed 2026-08-08 18:04:00 -06:00
Tables.js ui: nine leaf files off Semantic, and the components they needed 2026-08-08 18:04:00 -06:00
TaggedDeleteConfirmModal.js ui: Common.js and thirteen more files off Semantic 2026-08-08 18:04:00 -06:00
TaggedDeleteConfirmModal.test.js Models like Archive/Video/Doc can be deleted, even if they are tagged. User is shown a warning and must confirm deletion of tagged files. 2026-05-03 19:14:15 -06:00
Theme.tsx ui: toasts move to the top right, get readable titles, and get tests 2026-08-08 18:05:44 -06:00
ThemeProvider.test.js test: act on review — observe the wiring, and stop the soft assertions 2026-08-08 18:05:45 -06:00
ThemeSamplePage.js style: spell it "color" everywhere 2026-08-08 18:05:50 -06:00
Upload.js ui: migrate Downloads, Upload, and BulkTagModal off Semantic 2026-08-08 18:04:02 -06:00
Vars.js Restore "Most Views" download order 2026-07-07 16:34:50 -06:00
VideoPlayer.js ui: migrate VideoPlayer.js off Semantic UI React 2026-08-08 18:04:01 -06:00
VideoPlayer.test.js videos: address review — tighten auto-caption detection 2026-07-16 18:29:18 -06:00
Videos.js ui: act on review -- corner chrome, a swallowed className, and the poster frame 2026-08-08 18:05:47 -06:00
VncToggle.test.js ui: Common.js and thirteen more files off Semantic 2026-08-08 18:04:00 -06:00
Zim.js fix: an unnamed language code took down the whole Zim manage page 2026-08-08 18:05:49 -06:00
Zim.test.js fix: an unnamed language code took down the whole Zim manage page 2026-08-08 18:05:49 -06:00