wrolpi/app/src
Roland f5e223b62a fix: toasts were covering the navigation bar's controls
Six keyboard-shortcuts e2e tests started failing on CI: clicking the search
glyph was refused because a `mantine-Notification-title` was on top of it.

The toast container is fixed at `top: var(--mantine-spacing-md)` -- 16px --
while the bar occupies the first 54px of the page.  Every toast has therefore
been landing on the bar's right-hand corner: the search glyph, the hamburger,
Help and Admin.  For as long as the toast is up those controls cannot be
clicked, and an error toast is precisely the moment a user reaches for Admin.

It surfaced now because the previous commit gave the search glyph a proper hit
area.  At 18px it sat in the gap beneath the toast; grown to the height of the
bar, it moved into the overlap.  The toast has been covering that corner all
along -- there was nothing there to hit.  So this is not a test that needs
loosening: CI found a real defect that predates the change that exposed it.

Toasts now start below the bar.  `--navbar-height` is shared between the bar's
min-height and the offset so the two cannot drift, and the rule matches
`[data-position^='top']` so a future move to bottom-right does not silently
inherit a top offset.  Mantine's own positioning uses `:where()`, which has zero
specificity, so a single class wins.

Tested by `elementFromPoint` rather than by comparing rectangles: that is the
question Cypress's actionability check asks and the one a mouse asks.  A
geometry test would miss a toast that overlaps but sits behind, and a z-index
test would miss one that is in front but elsewhere on screen.  Three cases --
the search control, every control in the corner, and the offset itself, which is
stated separately because the first two would also pass on a toast that merely
happened to be narrow enough to miss at one viewport.  Removing the offset
reddens all three.

Confirmed on the running app with a real error toast up: toast top 70px, bar
bottom 54px, all six corner controls topmost at their own centres.  The e2e
spec passes locally, 12 of 12.

1124 jest / 62 suites, 199 in ui-layout.cy.js, clean npm run build.
2026-08-02 16:01:46 -06:00
..
api controller: VNC toggle, gated on the Desktop running 2026-07-29 18:10:05 -06:00
components fix: toasts were covering the navigation bar's controls 2026-08-02 16:01:46 -06:00
contexts test: one place for fixtures, real providers instead of mocked context modules 2026-07-30 16:44:40 -06:00
hooks ui: the corner triggers, the More button, and the search modal 2026-08-02 14:59:22 -06:00
themes review: measure what can be measured, and say what is not 2026-08-02 14:59:22 -06:00
types ui: the last Semantic UI file, and the stylesheet with it 2026-07-30 13:41:05 -06:00
api.js ui: thirty-five files off Semantic, leaving fifteen 2026-07-30 12:54:24 -06:00
App.css fix: toasts were covering the navigation bar's controls 2026-08-02 16:01:46 -06:00
App.js ui: the last Semantic UI file, and the stylesheet with it 2026-07-30 13:41:05 -06:00
DashboardPage.js ui: only the top modal answers Escape, and the audited widths 2026-08-02 16:01:46 -06:00
DashboardPage.test.js ui: thirty-five files off Semantic, leaving fifteen 2026-07-30 12:54:24 -06:00
Events.js ui: thirty-five files off Semantic, leaving fifteen 2026-07-30 12:54:24 -06:00
import-cycles.test.js fix: break the import cycle that put useCalculators in the TDZ 2026-08-02 12:41:23 -06:00
index.css ui: the last Semantic UI file, and the stylesheet with it 2026-07-30 13:41:05 -06:00
index.js Fixing changes before merge. 2023-02-08 21:18:51 -07:00
logo.svg Renaming examples to avoid grouping of pdf with ebooks. Reworking URLs for media files to avoid escaping url safe characters. 2023-03-29 13:46:39 -06:00
reportWebVitals.js Renaming examples to avoid grouping of pdf with ebooks. Reworking URLs for media files to avoid escaping url safe characters. 2023-03-29 13:46:39 -06:00
semantic-baseline.json ui: the last Semantic UI file, and the stylesheet with it 2026-07-30 13:41:05 -06:00
semantic-baseline.test.js build: uninstall Semantic UI 2026-07-30 14:50:47 -06:00
setupTests.js ui: Common.js and thirteen more files off Semantic 2026-07-30 11:55:39 -06:00
Tags.cy.js Video downloads have many more options. Downloads are migrated. 2024-11-28 09:48:57 -07:00
Tags.js ui: only the top modal answers Escape, and the audited widths 2026-08-02 16:01:46 -06:00
Tags.test.js ui: tags look like tags, and stay readable in every theme 2026-08-01 14:35:35 -06:00
test-fixtures.js test: check declared types, not just field names, and fix the three that were wrong 2026-07-30 17:34:36 -06:00
test-fixtures.test.js test: one place for fixtures, real providers instead of mocked context modules 2026-07-30 16:44:40 -06:00
test-utils.js test: the theme drives the colour scheme, and mockModule takes the module 2026-07-30 16:44:40 -06:00
test-utils.test.js test: the theme drives the colour scheme, and mockModule takes the module 2026-07-30 16:44:40 -06:00