wrolpi/app/src/components
Roland f5e223b62a fix: toasts were covering the navigation bar's controls
Six keyboard-shortcuts e2e tests started failing on CI: clicking the search
glyph was refused because a `mantine-Notification-title` was on top of it.

The toast container is fixed at `top: var(--mantine-spacing-md)` -- 16px --
while the bar occupies the first 54px of the page.  Every toast has therefore
been landing on the bar's right-hand corner: the search glyph, the hamburger,
Help and Admin.  For as long as the toast is up those controls cannot be
clicked, and an error toast is precisely the moment a user reaches for Admin.

It surfaced now because the previous commit gave the search glyph a proper hit
area.  At 18px it sat in the gap beneath the toast; grown to the height of the
bar, it moved into the overlap.  The toast has been covering that corner all
along -- there was nothing there to hit.  So this is not a test that needs
loosening: CI found a real defect that predates the change that exposed it.

Toasts now start below the bar.  `--navbar-height` is shared between the bar's
min-height and the offset so the two cannot drift, and the rule matches
`[data-position^='top']` so a future move to bottom-right does not silently
inherit a top offset.  Mantine's own positioning uses `:where()`, which has zero
specificity, so a single class wins.

Tested by `elementFromPoint` rather than by comparing rectangles: that is the
question Cypress's actionability check asks and the one a mouse asks.  A
geometry test would miss a toast that overlaps but sits behind, and a z-index
test would miss one that is in front but elsewhere on screen.  Three cases --
the search control, every control in the corner, and the offset itself, which is
stated separately because the first two would also pass on a toast that merely
happened to be narrow enough to miss at one viewport.  Removing the offset
reddens all three.

Confirmed on the running app with a real error toast up: toast top 70px, bar
bottom 54px, all six corner controls topmost at their own centres.  The e2e
spec passes locally, 12 of 12.

1124 jest / 62 suites, 199 in ui-layout.cy.js, clean npm run build.
2026-08-02 16:01:46 -06:00
..
admin ui: only the top modal answers Escape, and the audited widths 2026-08-02 16:01:46 -06:00
calculators fix: break the import cycle that put useCalculators in the TDZ 2026-08-02 12:41:23 -06:00
collections ui: only the top modal answers Escape, and the audited widths 2026-08-02 16:01:46 -06:00
inventory ui: only the top modal answers Escape, and the audited widths 2026-08-02 16:01:46 -06:00
ui fix: toasts were covering the navigation bar's controls 2026-08-02 16:01:46 -06:00
AddToPlaylist.js ui: Common.js and thirteen more files off Semantic 2026-07-30 11:55:39 -06:00
Apps.js fix: break the import cycle that put useCalculators in the TDZ 2026-08-02 12:41:23 -06:00
Archive.js ui: cards get legible titles, contained posters, and meta beside the title 2026-08-02 11:52:59 -06:00
ArchivePreview.js ui: Common.js and thirteen more files off Semantic 2026-07-30 11:55:39 -06:00
BulkTagModal.js ui: only the top modal answers Escape, and the audited widths 2026-08-02 16:01:46 -06:00
BulkTagModal.test.js ui: migrate Downloads, Upload, and BulkTagModal off Semantic 2026-07-30 13:10:51 -06:00
Calculators.js ui: fix the cypress failures, and two real defects behind them 2026-07-30 12:54:24 -06:00
CbzViewer.js ui: Common.js and thirteen more files off Semantic 2026-07-30 11:55:39 -06:00
Channels.cy.js Moving form fields. 2025-12-06 15:11:37 -07:00
Channels.js ui: only the top modal answers Escape, and the audited widths 2026-08-02 16:01:46 -06:00
Common.js ui: only the top modal answers Escape, and the audited widths 2026-08-02 16:01:46 -06:00
Common.test.js ui: act on review -- corner chrome, a swallowed className, and the poster frame 2026-08-02 11:52:59 -06:00
DatesSelector.js ui: thirty-five files off Semantic, leaving fifteen 2026-07-30 12:54:24 -06:00
DesktopToggle.test.js ui: Common.js and thirteen more files off Semantic 2026-07-30 11:55:39 -06:00
Docs.js ui: migrate Docs.js and Zim.js off Semantic UI React 2026-07-30 13:07:48 -06:00
DomainEditPage.test.js app: handle form fetch failures without unhandled rejection 2026-07-16 19:40:28 -06:00
DomainsPage.test.js Reformatting code. 2025-12-06 15:11:37 -07:00
DomainTagging.test.js test: one place for fixtures, real providers instead of mocked context modules 2026-07-30 16:44:40 -06:00
DonatePage.js ui: only the top modal answers Escape, and the audited widths 2026-08-02 16:01:46 -06:00
Download.cy.js build: uninstall Semantic UI 2026-07-30 14:50:47 -06:00
Download.js ui: thirty-five files off Semantic, leaving fifteen 2026-07-30 12:54:24 -06:00
Download.test.js Reformatting code. 2025-12-06 15:11:37 -07:00
ErrorBoundary.js ui: nine leaf files off Semantic, and the components they needed 2026-07-30 11:55:39 -06:00
FileBrowser.js test: act on review — the skeleton guard was reading the wrong layer 2026-08-01 16:10:10 -06:00
FileBrowser.test.js test: the theme drives the colour scheme, and mockModule takes the module 2026-07-30 16:44:40 -06:00
FilePreview.js ui: only the top modal answers Escape, and the audited widths 2026-08-02 16:01:46 -06:00
FilePreview.test.js File preview: Open in Slicer button for STL/3MF files. 2026-07-05 13:31:40 -06:00
Files.js ui: only the top modal answers Escape, and the audited widths 2026-08-02 16:01:46 -06:00
Flasher.js ui: only the top modal answers Escape, and the audited widths 2026-08-02 16:01:46 -06:00
Flasher.test.js ui: migrate Flasher.js off Semantic UI React 2026-07-30 13:13:39 -06:00
Headline.js ui: nine leaf files off Semantic, and the components they needed 2026-07-30 11:55:39 -06:00
HelpModal.js ui: thirty-five files off Semantic, leaving fifteen 2026-07-30 12:54:24 -06:00
KeyboardShortcutsProvider.js ui: only the top modal answers Escape, and the audited widths 2026-08-02 16:01:46 -06:00
Map.js ui: only the top modal answers Escape, and the audited widths 2026-08-02 16:01:46 -06:00
MapSearchView.js ui: centre the pagination strip 2026-08-02 13:11:31 -06:00
MapViewer.js ui: the monochrome themes draw a black basemap, not a dark one 2026-08-02 13:48:32 -06:00
Nav.js review: measure what can be measured, and say what is not 2026-08-02 14:59:22 -06:00
otp.js Move One-Time Pad encryption to the browser (#479) 2026-06-13 13:52:34 -06:00
otp.test.js Move One-Time Pad encryption to the browser (#479) 2026-06-13 13:52:34 -06:00
Placeholder.js ui: Common.js and thirteen more files off Semantic 2026-07-30 11:55:39 -06:00
Playlists.js ui: Channels.js and Playlists.js off Semantic 2026-07-30 13:02:57 -06:00
Playlists.test.js Add ordered collections (playlists): polymorphic items + item API (#475) 2026-06-11 19:46:34 -06:00
Search.js ui: the corner triggers, the More button, and the search modal 2026-08-02 14:59:22 -06:00
SearchFilterModal.test.js ui: thirty-five files off Semantic, leaving fifteen 2026-07-30 12:54:24 -06:00
Share.js ui: only the top modal answers Escape, and the audited widths 2026-08-02 16:01:46 -06:00
ShortcutHint.js Displaying cmd+k/ctrl+k global search keyboard shortcut suggestion. 2026-02-23 16:07:22 -07:00
SortableTable.js ui: nine leaf files off Semantic, and the components they needed 2026-07-30 11:55:39 -06:00
Tables.js ui: nine leaf files off Semantic, and the components they needed 2026-07-30 11:55:39 -06:00
TaggedDeleteConfirmModal.js ui: Common.js and thirteen more files off Semantic 2026-07-30 11:55:39 -06:00
TaggedDeleteConfirmModal.test.js Models like Archive/Video/Doc can be deleted, even if they are tagged. User is shown a warning and must confirm deletion of tagged files. 2026-05-03 19:14:15 -06:00
Theme.tsx ui: toasts move to the top right, get readable titles, and get tests 2026-08-01 15:27:39 -06:00
ThemeProvider.test.js test: act on review — observe the wiring, and stop the soft assertions 2026-08-01 15:27:39 -06:00
ThemeSamplePage.js ui: the corner triggers, the More button, and the search modal 2026-08-02 14:59:22 -06:00
Upload.js ui: migrate Downloads, Upload, and BulkTagModal off Semantic 2026-07-30 13:10:51 -06:00
Vars.js Restore "Most Views" download order 2026-07-07 16:34:50 -06:00
VideoPlayer.js ui: migrate VideoPlayer.js off Semantic UI React 2026-07-30 13:07:09 -06:00
VideoPlayer.test.js videos: address review — tighten auto-caption detection 2026-07-16 18:29:18 -06:00
Videos.js ui: act on review -- corner chrome, a swallowed className, and the poster frame 2026-08-02 11:52:59 -06:00
VncToggle.test.js ui: Common.js and thirteen more files off Semantic 2026-07-30 11:55:39 -06:00
Zim.js ui: only the top modal answers Escape, and the audited widths 2026-08-02 16:01:46 -06:00